Sorry it's taken so long for anyone to review this work.
On Wed, 2004-06-09 at 14:15, John Peacock wrote:
> I'd like to document again where we currently stand. The two patches I
> associated with the issue make keywords into a hash (as opposed to a
> struct) in a 100% API neutral fashion. Only the existing keywords are
> handled.
It seems like your patch does more than this; it adds an (undocumented)
props parameter to svn_subst_build_keywords2, and it introduces a
keyword_printf framework replacing the hardcoded keyword constructions
in the old svn_subst_build_keywords.
It appears that the proper API of svn_subst_build_keywords2 is going to
depend on the eventual nature of our custom keyword support. I don't
remember seeing, nor can I think up, any practical use cases for the
idea of simply allowing properties to be used as keywords (limited to
expanding $propname$ to $propname: propval$, as I understand it), so I'm
dubious that we'll want to go in that direction. The requests I have
seen are for things like $FreeBSD$, which would act similarly (though
perhaps not identically) to $Id$.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jun 16 01:50:45 2004