[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

svn_repos_trace_node_locations bug

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2004-06-15 23:40:41 CEST

Hi,

While debugging the rest of the get_locations patch, I found a bug in
svn_repos_trace_node_locations, which I'm not sure how to handle.

The problem is when one of the input revisions (in the array) is greater
than the peg revision. Then, the function checks if the path in the
greatest revision refers to the same node as the path in the peg revision.
Tha's done by string comparison of the paths. But when "" is passed in as
the path this fails, since svn_fs_history_prev will return "/" as the root
directory. The same problem arises when you pass in something like
"//path/path2//path3", even though this is allowd by the FS.

Is there some function to get the canonical path for a FS path (not
svn_path_canonicalize, obviously). Another way would be to get the
canonical path after the first call of svn_fs_history_prev. Is this
guaranteed to always give the same path as passed in to svn_fs_history
(but in a canonical form)?

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 15 23:30:40 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.