Re: ra_svn DOS potential (was Re: svn commit: r9946 - trunk/subversion/libsvn_ra_svn)

Greg Hudson wrote:

>On Fri, 2004-06-11 at 06:40, Branko ÄŒibej wrote:
>
>
>>This doesn't do much to avoid the DoS.
>>
>>
>
>It make the network act as a throttle on resource usage by not
>allocating all the memory at once. But you're right; particularly in
>threaded mode (where you can't just set a resource limit), it's not a
>very comprehensive solution.
>
>
[...]

> * The client imposes no limit on communication from the server.
> * Before initial authentication, we impose a very small limit,
> on the order of 4-8K.
> * After authentication (even if it's anonymous), if the connection
> has read access, it gets a medium limit, on the order of 64K.
> * If a connection has write access, we impose no limit.
>
>
I think this is a reasonable approach. It will still allow an untrusted
server to crash a client (the program, not the machine, we can hope),
but I don't see that as a very big problem. I wonder if we can make
ra_dav safe in a similar way, or if we have to.

-- 
Brane ÄŒibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org