Re: [PATCH] New error code needed for javahl binding. Next try. Repost

Patrick Mayweg wrote:

>Index: subversion/include/svn_error_codes.h
>===================================================================
>--- subversion/include/svn_error_codes.h (revision 9921)
>+++ subversion/include/svn_error_codes.h (working copy)
>@@ -853,6 +853,14 @@
> SVN_ERR_MISC_CATEGORY_START + 19,
> "Incompatible library version")
>
>+ /* language bindings may catch/detect exception in their language while
>+ doing callbacks. To pass these exceptions thru the subversion code
>+ unchanged, a special error code is needed. This error code is not
>+ user visibible */
>+ SVN_ERRDEF (SVN_ERR_BINDING_EXCEPTION_PASSTHRU,
>+ SVN_ERR_MISC_CATEGORY_START + 20,
>+ "Binding exception has been passed thru")
>+
>
>

How about calling this just SVN_ERR_BINDING_EXCEPTION, and instead of
creating a new error code, make it an alias for
SVN_ERR_SWIG_PY_EXCEPTION_SET (and deprecating that one, of course). I
don't think we need two such error codes, or a Python-specific one. Also
if I remember your usage correctly, there's no chance of this error code
being misinterpreted.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org