[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Check translation format strings

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2004-06-11 22:08:03 CEST

Hi,

Are there any objections to the following patch? I don't know how
old/widely available this flag is in msgfmt. The problem with -c is that,
at least in my msgfmt, it wants an Last-Translator header, and sees it as
a fatal error if there is none.

The reason for this is that it will turn run-time crashes into build
errors.

//Peter

Check format strings in message translations during the build.

* Makefile.in (.spo.mo): Add --check-format option to msgfmt command line.

Index: Makefile.in
===================================================================
--- Makefile.in (revision 9965)
+++ Makefile.in (arbetskopia)
@@ -530,7 +530,7 @@
         sed '/^"Content-Type: text\/plain; charset=UTF-8\\n"$$/d' $< > $@

 .spo.mo:
- $(MSGFMT) -o $@ $<
+ $(MSGFMT) --check-format -o $@ $<

 install-docs: install-man @INSTALL_INFO@

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 11 21:57:48 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.