[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Warnings in fs_fs compilation on Win32

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2004-06-10 17:36:49 CEST

On Thu, 2004-06-10 at 02:40, Branko Čibej wrote:
> I /think/ all three casts are safe.

Well, the FS files aren't untrusted data.

The patch looks fine.

I was thinking of proposing that we add -Wsign-compare to the gcc
warning flags in configure.in, but it doesn't seem to be present in gcc
2.95. And even gcc 3.4 doesn't seem to have an option to warn about
implicit narrowing of integer types.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 10 17:37:55 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.