Travis P <svn@castle.fastmail.fm> writes:
> From one not-quite-forgotten thread in March (which I just bumped into
> again a few days ago), probably two new issues are warranted.
>
> The first is the simpler case. Probably very simple.
>
> [1] Ben Collins-Sussman wrote:
>
> While we can't notice a control-C while responding to the
> [svn password] prompt, we ought to be able to notice the signal
> *between* prompts!
>
> http://www.contactor.se/~dast/svnusers/archive-2004-03/1590.shtml
Want to file?
> [2] Ben Collins-Sussman wrote:
>
> The problem here is that the prompting function (which is reading your
> keystrokes) isn't checking to see if Ctrl-C has been noticed by the
> signal handler.
>
> At the moment, there's no way for that to happen, since the proper
> signal/cancellation func isn't even being passed into the prompting
> func. Perhaps we could add a new prompting API in svn 1.1 that takes
> such an argument.
>
> http://www.contactor.se/~dast/svnusers/archive-2004-03/1587.shtml
Isn't the prompting function basically apr_password_get(), that is, we
didn't write it and don't control the API, and can't run anything
between the keystrokes? We could pass a cancellation checker into
subversion/clients/cmdline/prompt.c:prompt(), but I don't see how we
could get it into apr_password_get(), where it really needs to be...
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jun 9 20:24:13 2004