Re: pre-commit hook that stops CaSe-InSenSiTive collisions

Martin Tomes wrote:

>use strict;
>
>
use warnings; would be a good idea here.

>my $opSys = $^O;
>
>my $svnlook;
>my $openstr;
>
># Please check the path to svnlook is correct...
>if ($opSys eq 'MSWin32') {
> $svnlook = '"c:\Program Files\subversion\bin\svnlook.exe"';
> $openstr = '-|';
>} else {
> $svnlook = '/usr/local/bin/svnlook';
> $openstr = '-|:utf8';
>}
>
>
    * I suggest you move configurable paramters to the very top of the
      script, so that they're easier to find.
    * Why doesn't the Win32 variant open the svnlook pipe in utf8 mode?
      I wonder if svnlook does, in fact, print utf8 paths. Hmmm... no it
      does not. Svnlook will only write utf-8 filenames if your current
      locale is utf-8. So much for this script then -- it won't work.
      You should use the bindings instead.
    * Which version of Perl do you need for '-l:utf8'? Maybe you need a
      "require" line.

># If there is too much debug output to STDERR subversion doesn't like it, so,
># if a lot of output is expected send it to a file instead.
>if ($debug > 1) {
> if ($opSys eq 'MSWin32') {
> open(STDERR, ">c:/svnlog.txt");
> } else {
> open(STDERR, ">/tmp/svnlog.txt");
> }
>}
>
>
There is sucha thing as File::Temp in Perl...

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org