Re: [Issue 1904] New - seg fault on 'svn propdel --revprop ...'

Branko Čibej <brane@xbc.nu> writes:
> I'm tempted to close this one as "invalid" because it uses the issue
> tracker for discussion that belongs on the dev@list. :-)

No, actually that's *this* mail. But, fortunately, this _is_ on the
dev list... :-).

(It's not discussion until there's more than one person. Before that,
it's "recording everything I know before the phone rings and I lose my
mental stack", ahem...)

> Anyway: You described two bugs and a broken docstring. IMHO they should
> all be fixed in the "obvious" way. The post-revprop-change handler
> should pipe the old value to the hook. I'm not sure what the new value
> is for a deleted property, though; I suppose "empty" is the best we can
> do, except that the hook would have no way of knowing that the property
> was deleted. Same goes for the old value of an added prop in the
> post-change hook.

Yep, this is exactly what I was worrying about...

> I suppose adding another parameter to the hook (action: added, modified,
> deleted?) wouldn't be too bad for a 1.1? I'd tend to view script
> parameters the same way as structure fields, since trailing ones can be
> ignored. We should put that in the versioning doc, though.

...and that's a good solution, yes.

> Yes, and modify mailer.py and propchange-email.pl to handle the new
> parameter and show diffs as expected.

Separate change, but yes, of course.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 4 03:49:45 2004