Re: [Issue 1904] New - seg fault on 'svn propdel --revprop ...'

Branko Čibej <brane@xbc.nu> writes:

> The post-revprop-change handler should pipe the old value to the
> hook.

Haven't we been here before? There was some reason why piping didn't
work out.

> I'm not sure what the new value is for a deleted property, though; I
> suppose "empty" is the best we can do, except that the hook would
> have no way of knowing that the property was deleted. Same goes for
> the old value of an added prop in the post-change hook.

But now you're talking about a new value instead of an old one. What?

A post-revprop-change script need not be told the new value -- the
onus is on the script writer to ask the filesystem for the new value,
and to be able to tell the difference between "missing" and "empty".
It should be told the *old* value, though. The opposite applies for
the pre-revprop-change hook, which already knows the old value (by
asking the repository directly), but needs to be told the new
value-to-be.

Of course, it occurs to me that we have (and have always had) race
conditions here -- it's possible that between the time Harry's
propchange is made and the time his hooks query for the new value,
Sally might have changed the property yet again. I fear the only way
to get this working in full is for both the pre- and post- revprop
hooks to accept on stdin both old and new values, perhaps in an XML
message.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 4 00:56:27 2004