[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] In build system hashing problem.

From: Justin Erenkrantz <justin_at_erenkrantz.com>
Date: 2004-05-31 07:23:37 CEST

On Sun, May 30, 2004 at 05:14:34PM +0200, Patrick Mayweg wrote:
> Hi,
> In the building system there is the class "DependencyNode" in the file
> build/generator/gen_base.py. This class defines the methods __hash__ and
> __cmp__,which uses the member "filename" for hashing and comparision.
> The derived class "TargetJava" set "filename" to '' so all objects
> of the derived classes "TargetJavaClasses" and "TargetJavaHeaders"
> are for hashing and comparision the same objects. This is wrong. The
> patch uses the member "name" if the member "filename" contains an empty
> string for hashing and comparision.

At one point, filename needed to be blank to avoid generating some false make
file rules that weren't required for Java files. I think I eventually fixed
the 'root' cause later on - so it may be possible to just set filename to name
and see if it builds. -- justin

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon May 31 07:23:58 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.