[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] The blame speedup

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2004-05-31 06:57:05 CEST

On Sun, 2004-05-30 at 19:33, Peter N. Lundblad wrote:
> As you'll notice, this is work in progress. If anyone has time and
> interest, I'd like to ask for some review. Especially, I'm interested in
> comments on the client interface. I've settled on letting the RA layer
> create temporary files for the contents, giving the filename to the client
> callback. It is guaranteed that the file is available as long as is needed
> by the blame command. So, I'm not exposing any deltas in the client
> interface. This is inconsistent with some other interfaces, but it avoids
> having ra_local compute deltas between all revisions. As I've said
> earlier, deltas will be used in the network protocols.

Hm. In general, we're much happier with streams than files, at the API
level. The file-rev callback could provide a writable stream to the RA
function. In "svn blame", that callback would just write out a
temporary file to be passed to libsvn_diff (using

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon May 31 06:57:19 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.