[Next resend.]
---------- Forwarded message ----------
Date: Mon, 24 May 2004 21:20:13 +0200 (CEST)
From: Peter N. Lundblad <peter@famlundblad.se>
To: dev@subversion.tigris.org
Cc: dev@subversion.tigris.org
Subject: Re: Speeding up blame
On Mon, 10 May 2004, Greg Hudson wrote:
> On Mon, 2004-05-10 at 06:35, Peter N. Lundblad wrote:
> > typedef svn_error_t *(*svn_ra_file_revision_handler_func_t)(void *baton,
> > svn_revnum_t rev,
> > svn_txdelta_window_handler_t *handler, void **handler_baton,
> > apr_hash_t *changedprops);
>
> That might be best. Try to avoid the cosmic gargantuan type name;
> something like svn_ra_file_rev_handler_t should be sufficient.
>
OK. This isn't my current prototype, but still we have this little
handler. It will be used in a repository function as well as an RA
function. So I'm not sure in which "namespace" it should live (svn_ra or
svn_repos or just svn_, as the log receiver does). Also does it belong in
svntypes.h. I don't think client code should depend on svn_repos.h and
vice versa.
Thanks,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 25 21:55:00 2004