[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: More libsvn_wc efficiency improvements.

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2004-05-24 19:30:52 CEST

Josh Pieper <jjp@pobox.com> writes:

> Yes, but it was not an obvious call. Currently, svn_wc__entry_modify
> clears the cache for the pruned list after every modification. This
> means that the next time the pruned list is requested it must be
> regenerated. This happened for every entries list modification. By
> changing svn_wc__entry_modify to modify both the full and pruned list
> simulataneously, prune_deleted only needs to be called the first time
> a new entries list is loaded. The change to prune_deleted was just a
> minor optimization after the fact.

OK. I suppose it would be possible to leave in the bit that shares
the hash by making svn_wc__entry_modify a bit more intelligent--it
could determine whether the hash was shared or not and modify one or
two hashes as required, I guess it might also need to be responsible
for unsharing if the modification created a deleted entry. I don't
know whether the memory saving is sufficiently important, but entry
cache memory does have a long lifetime.

Philip Martin
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon May 24 19:31:15 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.