[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] I need a new error code

From: Branko ─îibej <brane_at_xbc.nu>
Date: 2004-05-24 02:18:43 CEST

Patrick Mayweg wrote:

> Hi,
> I need a new error code for the javahl binding, but I am not sure if I
> may just commit my change to svn_error_codes.h
> Patrick
>
> Index: subversion/include/svn_error_codes.h
> ===================================================================
> --- subversion/include/svn_error_codes.h (revision 9852)
> +++ subversion/include/svn_error_codes.h (working copy)
> @@ -853,6 +853,10 @@
> SVN_ERR_MISC_CATEGORY_START + 19,
> "Incompatible library version")
>
> + SVN_ERRDEF (SVN_ERR_JAVAHL_EXCEPTION_RECEIVED,
> + SVN_ERR_MISC_CATEGORY_START + 20,
> + "Java exception has been reveived from callback")
> +
> /* command-line client errors */
>
> SVN_ERRDEF (SVN_ERR_CL_ARG_PARSING_ERROR,

So let me understand how this looks: you have something like:

    Java code -> javahl -> svn library -> javahl -> Java callback

Is that correct? And you want to convert an exception in the Java
callback to an error returned from the javahl callback wrapper to the
svn library. Hm. It seems somehow wrong to add binding-specific errors
to the core error list. OTOH we already have a SWIG/Python specific
error code, so it's not as if you'd be adding anything we've not seen
before. I'd rather see a more generic code, though, that other bindings
can use, too.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon May 24 02:20:13 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.