[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Execute groups of log-files, was (Re: Improving the performance of libsvn_wc for checkouts/updates/switches)

From: Josh Pieper <jjp_at_pobox.com>
Date: 2004-05-23 23:07:23 CEST

Josh Pieper wrote:
> Philip Martin wrote:
> > The problem is that ra_dav is the only layer that uses wcprops, if you
> > only test over ra_local you won't see wcprops related failures.
> >
> > The original problem generated some dev list discussion between me and
> > Karl, and some code from Karl. As I recall the problem was that an
> > interrupted update caused the wcprops and the text-base/revision to be
> > out-of-sync (I can't remember which one was wrong). I don't know
> > whether the wcprops code is still fragile, or whether Karl's change
> > fixed it.
> Ok, I did some testing over ra_dav and found no problems. It passes
> the whole test-suite, plus I did quite a bit of checkouts/updating and
> interrupting without any issues. I also looked at issue #1136, which
> I think is what you were referring to here. I was unable to reproduce
> that failure with the new code either.
> One last concern. Do we need to be worried about compatability? This
> change would prevent trunk from running the log files from older
> working copies since their names have changed. Should I hack in
> something to try "log" before trying "log.1" or can we just accept
> that amount of change?

It turns out that keeping compatability wasn't too hard, it in fact
reduced the number of files I had to touch. Therefore, I went ahead
and committed this optimization in r9868.

There is one other optimization I want to make to the working copy
code, which should get it finally to O(n) for very large directory
sizes. I'll post that in a new thread later on, this thread is
starting to get pretty deep.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun May 23 23:07:42 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.