[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Svnserve still exiting randomly in threaded mode

From: Branko Čibej <brane_at_xbc.nu>
Date: 2004-05-18 23:52:51 CEST

Greg Hudson wrote:

>-1 on using global variables.
You'll have to be a bit more persuasive than that. Either you use them
in the logging implementation, or in the code, or in syslog, or
wherever. Bout you can't reasonably avoid them in this case. Note that
the problem with golobal variables is when they're in a (possibly
shared) library. In this case, it's one variable in svnserve, we can
ensure single-threaded initialization, and it's readonly from that point

>And, once again, stop with the damn cycle micromanagement. Unless you
>have a benchmark showing measurably worse performance from evaluating
>the log level inside the logging function, don't clutter up the caller,
>macros or no.
Evaluating the logging level is not the issue. Evaluating the function
parameters during the call _is_. I don't have numbers handy, but believe
me, I know from personal experience that it _can_ become an issue when
the logging is verbose enough. If the logging isn't even potentially
verbose enough for this to matter, then it's also next to useless for
locating bugs. You want to be able to tell a user whose bug you can't
reproduce to turn on maximum logging and try again. If the issue isn't
triggered by timing, you've got a much better chance to spot the bug
from reading the logs than you'd ever be able to do with a debugger.

-- Brane

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 18 23:53:24 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.