Greg Hudson wrote:
>On Mon, 2004-05-17 at 21:49, Branko Čibej wrote:
>
>
>> * The fact that svnserve does not do any logging is a big problem here
>>
>>
>
>Any ideas on how we should implement a portable logging primitive? I
>feel like it's our responsibility to use syslog() by default on Unix,
>but obviously that's not portable to Windows. httpd isn't much of an
>example; I think it only believes in logging to a file under the server
>root, which isn't a concept we have.
>
>
Supporting syslog() on Unix would be nice, as well as logging to a file
on both platforms. We don't need a server root, just a log file
directory for that. Picking a default wouldn't be that hard; $prefix/log
is the obvious choice on both Unix and Windows. We would have to
introduce a global svnserve config file, though.
>>I think we need to put a pretty hugh priority on stabilizing threaded
>>svnserve, and adding server-side logging.
>>
>>
>
>Much as I'd like to have server-side logging, I don't see how it's
>connected to the other problem. The process died (with status 58, which
>is weird--I don't think any part of our code exits with any status other
>than 0 or 1), and you'll need a debugger to figure out why.
>
>
That's true...
>(Unless you mean server-side logging at the level of printf debugging.
>That seems excessive.)
>
>
Oh, I do think we should have debug-level logging, but not turned on by
default.
>>(I'm assuming the same would happen on Linux in threaded mode)
>>
>>
>
>I can't make it happen. The odd exit status makes me think the problem
>is somewhere deep and Windows-specific, which means I can't help much.
>
>
Yes... I can't reproduce it either. It's horrible, really :-( In my
experience, logging to a file is the best way to find these bugs.
>John Peacock wrote:
>
>
>>or can I just add a new commandline switch that spews logs on STDOUT
>>(which is all I need)?
>>
>>
>
>Well, I don't think we'd have anything very useful if that's all we did,
>but it would be something.
>
>
>
>>Anyone want to nominate /how much/ logging happens [...]?
>>
>>
>
>syslog has a good mechanism for this, and I'd like to use it if the
>Windows equivalent isn't too screwy.
>
>
I don't think it would be very hard to reproduce syslog behavious on
Windows. Actually, I'd be against reinventing the wheel here, and just
use log4c (http://log4c.sourceforge.net/). I think it can use syslog on
Unix automagically.
>I'm not really keen on having "really compulsive debugging logs"
>cluttering up our code, particularly because we'd have to delve into the
>library code before it would be very useful. Informational logs on what
>client requests are being performed is as deep as I'd like to go.
>
>Branko wrote:
>
>
>>and also a global config file (/etc/svn/svnserve?)/
>>
>>
>
>We don't have a global svnserve config file. Partly because it's
>simpler to declare that all configuration happens at the repository
>level,
>
Well, logging could be an exception...
>and partly because I have no idea how to locate a global
>configuration file under Windows.
>
Of course we do. All other command-line tools understand system-wide
configuration on Windows, svnserve doesn't need to be any different. The
mechanism is already in our code.
>(httpd, once again, went its own route and invented the "conf" subdir of the server root.)
>
>
We user /etc/svn on Unix, "$ALLUSERSPROFILE/Application Data/Subversion"
and the global registry on Windows.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 18 04:37:02 2004