[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r9716 - trunk/subversion/libsvn_wc

From: Ben Reser <ben_at_reser.org>
Date: 2004-05-18 00:07:21 CEST

On Mon, May 17, 2004 at 09:29:56AM -0500, kfogel@collab.net wrote:
> Ben Reser <ben@reser.org> writes:
> > As far as harp on this stuff. I don't see how this is any less
> > appropriate than people harping on spaces between parenthesis.
> > Especially considering that the style guidelines that we're supposedly
> > following says you should do so:
> I think Greg's point was precisely that it's a style call, not an
> efficiency issue.

Maybe in some cases he'd be right. But in this case we're allocating
the memory in the for loop, which means we're allocating and freeing
memory on each pass of the loop. This particular loop happens to
iterate over every file in a working copy.

On top of that sometimes the dirent_kind pointer pointed at heap memory
and sometimes and stack memory.

At any rate, r9757 fixes this.

Ben Reser <ben@reser.org>
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 18 00:07:38 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.