[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] add --targets to some subcommands that are missing th em.

From: Shatzer, Larry <Larry.Shatzer_at_Spirent.com>
Date: 2004-05-17 21:04:53 CEST

> -----Original Message-----
> From: kfogel@collab.net [mailto:kfogel@collab.net]
> Sent: Monday, May 17, 2004 9:27 AM
> To: Shatzer, Larry
> Cc: 'dev@subversion.tigris.org'
> Subject: Re: [PATCH] add --targets to some subcommands that
> are missing
> them.
>
> Quick question: did you run the test suite to see if getopt_tests
> needs to be adjusted for this? (I haven't, I just know that this is
> often a gotcha with adding options...)

Ooops! There's a test that fails now, but an easy fix.

Updated patch to include test update. This brings a question to mind, I can
see the order the option is listed will change the output from help. Should
we be putting target option earlier in the list? Or is there some cleanup in
order to make all the options in a consistent order?

> I assume you tested the new functionality itself, of course :-).

A limited check of a few areas.

-- Larry

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Mon May 17 21:07:11 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.