Re: svn commit: r9697 - in trunk/subversion: clients/cmdline include libsvn_client libsvn_subr

On Thu, 2004-05-13 at 21:00, Branko Èibej wrote:
> No, it would make the code wrong IMHO because it would stop at the first
> incompatibility instead of listing them all.

Sorry, I missed that you were chaining the errors together. I continue
to believe that it's a mistake to chain together unrelated errors
(nested errors should have an inner-to-outer relationship, not a simple
concatenation relationship), but we do so in other parts of the code
already.

On the other hand, this error-generator callback strikes me as horribly
over-engineered. We have no other functions which use callbacks to
generate error messages. If the caller needs to add information to the
error message generated by the library routine, it can do so using error
chaining (of the more proper variety).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri May 14 03:15:32 2004