Re: Bad XML error with bad date in entries

Lele Gaifax <lele@nautilus.homeip.net> writes:

> I solved the problem with sed... Maybe the SVN_ERR_BAD_DATE returned
> by the parser should appear into the final message.

Well, at least the default text for that error code should be shown.
And a cursory glance at the code makes me think that it really should
be working since the XML error is created as a wrapper around the
actual error returned from the parser (which should be
SVN_ERR_BAD_DATE in this case).

Ah, I think I see. Bear with me, though, I'm just reading code, not
running gdb or anything.

Our error printing code has these rules for each item in the chain:
  (1) don't show the generic error if a more precise message exists
  (2) don't show the generic error if the previous error we printed
      had the same generic error.

In this case, we would have this chain:
   SVN_ERR_BAD_DATE, "XML parser failed in ''"
   SVN_ERR_BAD_DATE, NULL

So the printing code chooses to print the first chain link's specific
message, and then nothing for the second link.

I think the fix here is to not use SVN_ERR_W at entries.c:666, but
instead wrap the error with a different code like SVN_ERR_XML_MALFORMED.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu May 13 17:02:41 2004