[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] sprintf elimination, take 2

From: Erik Huelsmann <e.huelsmann_at_gmx.net>
Date: 2004-05-13 08:01:28 CEST

> > statements inside the if(detailed) clause). I wonder why you didn't
> > change all sprintf's throughout the code, e.g. those in
> libsvn_repos/dump.c?
> >
> Did in that file too, now. NOw we just have sprintf in test cases (who
> cares?), svndumpfilter/main.c (missing pool arguments) and utf.c and
> path.c. The two last construct strings in place and carefully make sure
> that enough space is allocated. I think extra allocation there is
> overkill.

Changing the function signature in svndumpfilter/main.c would be fine.
There is no change in the public API by adding a pool paramater to a private
function. I should have been more exact.



NEU : GMX Internet.FreeDSL
Ab sofort DSL-Tarif ohne Grundgebühr: http://www.gmx.net/dsl
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu May 13 08:01:46 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.