[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Speeding up blame

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2004-05-10 17:05:59 CEST

On Mon, 2004-05-10 at 06:35, Peter N. Lundblad wrote:
> OK. Should I use the svn_delta_editor_t mechanism for this new function.
> It would be used in a somewhat unusual way it seems, since
> apply_text_delta would be called many times on the same file.

If we're using the editor implementation, it would have to be done as a
series of independent edits, or we'd be abusing the editor contracts. I
would only recommend taking this route if we foresee extending this
function to handle directories as well as files, and I haven't thought
through the ramifications of that (nor have I identified a use case for
> typedef svn_error_t *(*svn_ra_file_revision_handler_func_t)(void *baton,
> svn_revnum_t rev,
> svn_txdelta_window_handler_t *handler, void **handler_baton,
> apr_hash_t *changedprops);

That might be best. Try to avoid the cosmic gargantuan type name;
something like svn_ra_file_rev_handler_t should be sufficient.

> or something. IN that case, we could add the information needed for blame
> (path, author, date), but this is maybe too specialized for an RA layer
> function?

Good question. We could just pass all the rev-props as a hash; that
doesn't seem too specialized.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon May 10 17:06:19 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.