Re: [bug] FSFS errors when doing simultaneous commits - win32 apr_file_mktemp is broken

Josh Pieper wrote:
> C.A.T.Magic wrote:
>
>>maybe a simple minded aproach will do a better job:
>>(pseudocode)
>> int r = head_revision;
>> int t = 1;
>> while ( mkdir("$r-$t")==DIR_EXISTS ) t++;

> This is essentially what I did by using svn_io_open_unique_file. Try
> r9662 and see how it goes.

great, that finally solved all the commit problems :)

but noticed 2 more things:
its always starting with an "_2" suffix (never _0 or _1)
and it would be safer to test for the 3243_2.txn _directory_
directly instead of testing for a _file_ first.
because if things go bad, then there is an existing
   3242_2.txn directory but no 3242_2 temp-file, which would
lead to permanent commit errors. svn_io_open_unique_dir ? :)

thanks
:-)
c.a.t.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon May 10 00:49:35 2004