[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: first_time variable in subversion/libsvn_fs_fs/fs_fs.c

From: Josh Pieper <jjp_at_pobox.com>
Date: 2004-05-07 23:18:05 CEST

Henderson, Michael D wrote:
> I don't know if it's appropriate to ask this here, but I'm looking
> at subversion/libsvn_fs_fs/fs_fs.c from r9649, in the hash_read
> function, and I don't understand the first_time variable. It looks
> like it's initialized to 1, then almost immediately set to 0 in the
> while loop and not used anywhere else. The comment on line 79 seems
> to imply that the variable should be used in the surrounding if
> statement.

This is the exactly correct place to mention this, and yes, first_time
should be used in the conditional. This hash_read function was copied
from elsewhere, I must have accidentally removed that clause when I
was converting it to read from a stream. No dire consequences, it
will just incorrectly not return an error upon an unexpected end of
file. I will fix it shortly.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat May 8 01:05:10 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.