Re: svn commit: r9622 - trunk/subversion/po

Branko Čibej <brane@xbc.nu> writes:
> You're trying to forbid empty log messages here, yes? I'd suggest not
> opening an attack path by letting echo expand shell-metas in the $LOG
> variable; so,
>
> /usr/local/bin/svnlook log ${REPOS} -t ${TXN} | \
> grep '[a-zA-Z0-9]' > /dev/null || exit 1

Thanks! And now that I've posted the old code to a public list, I
think I'll, uh... make this change right now. AHem.

> Yup. Although I'd do something similar as before:
>
> /mysterious/super/secret/path/to/verify-po.py ${REPOS} ${TXN} || exit 1

Cleaner idiom anyway.

> >By the way, is there any reason not to put "#!/usr/bin/env python" at
> >the top of verify-po.py?
>
> None at all.

Then consider it done :-).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri May 7 15:58:51 2004