[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]: Issue #1093, request for extra eyes

From: Josh Pieper <jpieper_at_andrew.cmu.edu>
Date: 2004-05-04 23:30:03 CEST

C. Michael Pilato wrote:
> Wouldn't libsvn_client/ra.c do the trick? Seems appropriately
> scoped for a function named such as yours.
>
> As for the name itself, "get_ra" doesn't really mean anything to me,
> and "_from_path_or_url" can probably be reduced to "_from_path", or
> eliminated altogether.
>
> So how about libsvn_client/ra.c:svn_client__ra_lib_from_path?

Peter N. Lundblad wrote:
> On Tue, 4 May 2004, Josh Pieper wrote:
> > --- subversion/libsvn_client/util.c (revision 0)
> > +++ subversion/libsvn_client/util.c (revision 0)
> > @@ -0,0 +1,122 @@
> [...]
> > +/*
> > + return svn_error_createf (SVN_ERR_ENTRY_MISSING_URL, NULL,
> > + "'%s' has no URL", path_or_url);
> Not what you asked for, but this string needs to be marked for
> translation. I think it's a good idea to do this in new code (even if it
> is factored from other functions).

Both good ideas. Thanks for looking over it!

-Josh

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 4 23:31:25 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.