[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: FS abstraction and circular dependencies

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2004-05-02 00:47:22 CEST

On Sat, 2004-05-01 at 18:17, Max Bowsher wrote:
> Attached is a first draft patch, although I've called it libsvn_fs_subr.

Hm. An important thing to call out about your patch is that
libsvn_fs_subr implements some, but not all, of the FS API, in order
that FS modules may consume some, but not all, of the public FS API.

I am always a bit nervous about "some, but not all" contracts,
especially when there is no simple way to spell out what's in the
"some." So I had actually been assuming that libsvn_fs_subr would
contain only internal routines, and libsvn_fs (the loader library) would
wrap around them. When I did the symbol renaming in libsvn_fs_base, I
went to a bunch of effort to make sure that libsvn_fs_base did not
consume any of the svn_fs API except for the ID routines; a similar
amount of effort might still be required for libsvn_fs_fs.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun May 2 00:48:13 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.