[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: RFC: svn_io_file_flush_to_disk

From: Branko ─îibej <brane_at_xbc.nu>
Date: 2004-05-01 21:24:26 CEST

Josh Pieper wrote:

>Branko ??ibej wrote:
>
>
>>Josh Pieper wrote:
>>
>>
>>>+ FlushFileBuffers (filehand);
>>>
>>>
>>>
>>>
>>How about checking the return value here, too?
>>
>>
>
>I would have, but I don't know how. I copied the code for flushing on
>Windows verbatim from another APR function, which did not check the
>error code.
>
>
Hm. I wonder why the error is ignored in APR... possibly a bug?

>>Of course, on Windows it would be much better if APR knew how to open
>>the file with FILE_FLAG_WRITETHROUGH...perhaps another flag to
>>apr_file_open that would cause apr_file_close to call fsync on Unix, but
>>open the file in writethrough mode on Windows?
>>
>>
>
>Ummm, I have no access to Windows systems and the only developer
>documentation I have is the online MSDN thing, which isn't that
>pleasant to use. Can I check this in with moving those two lines out
>of the conditional and let you/other Win32 experts handle the Windows
>side of things?
>
>
O.K. :-)
I'd assumed you knew Windows, since you were writing Windows code, heh,
but go ahead and I'll polish it up.

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat May 1 21:25:53 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.