[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Get-Locations TNG Rev. 26 - Using the New Specification

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2004-04-29 19:54:45 CEST

On Wed, 2004-04-28 at 09:49, C. Michael Pilato wrote:
> Shlomi Fish <shlomif@iglu.org.il> writes:
>
> > <<<
> > Adds an libsvn_fs layer function to efficiently trace the file
> > historical (and to a limited extent) location based on its peg
> > revision+path.
>
> How many times do I have to say this? PUT THIS FUNCTIONALITY INTO THE
> SVN_REPOS LIBRARY, NOT THE SVN_FS LIBRARY. Your first clue should be
> the fact that your tree.c additions do nothing but consume public
> libsvn_fs APIs. I'm a fully -1 on your touching libsvn_fs at all for
> this change.

Whoops, I completely agree with Mike, but also completely forgot about
this. Sorry for not reiterating in IRC, Shlomi.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 29 19:58:47 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.