[Fwd: Re: [PATCH] including stdlib in source files]

[Forwarded]

-------- Original Message --------
Subject: Re: [PATCH] including stdlib in source files
Date: Tue, 20 Apr 2004 00:01:00 -0300
From: H. Hernan Moraldo <games@moraldo.com.ar>
Reply-To: games@moraldo.com.ar
Organization: Moraldo Games
To: Julian Foad <julianfoad@btopenworld.com>
References: <4050FBAE.7010506@btopenworld.com> <40510AB6.5000003@btopenworld.com> <40510F61.5040404@btopenworld.com> <1079056421.3470.28.camel@linmachine> <1079105281.3256.9.camel@linmachine> <40572D0A.7030400@btopenworld.com>

Julian,

These days I'm terribly busy with the work at my company. I don't think
I'll be correcting the patch in the short term. I'm sorry, when I have
more time I'll try to help SVN development again.

Best regards,

-- 
H. Hernan Moraldo
Moraldo Games
http://games.moraldo.com.ar/
El mar, 16-03-2004 a las 13:36, Julian Foad escribió:
> H. Hernan Moraldo wrote:
> > Log message:
> > 
> > Include stdlib.h on files that were including this indirectly, through
> > svn_types.h.
> > 
> > * subversion/svnadmin/main.c
> > * subversion/svnlook/main.c
> > * subversion/clients/cmdline/main.c
> > * subversion/tests/libsvn_subr/target-test.c
> > * subversion/svndumpfilter/main.c
> > * subversion/svnserve/main.c
> > * subversion/svnversion/main.c
> >    stdlib.h is now directly #included on these
> >    files.
> 
> This patch is incomplete.  Those are only a few of the files that should include <stdlib.h> directly.  There are many more.  Remove "#include <stdlib.h>" from svn_types.h and then look for warnings like this:
> 
> /home/julianfoad/src/subversion/subversion/libsvn_delta/path_driver.c:158: warning: implicit declaration of function `qsort'
> 
> - Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org