[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r9496 - in trunk/subversion: include libsvn_delta tests/libsvn_fs

From: Tobias Ringstrom <tobias_at_ringstrom.mine.nu>
Date: 2004-04-26 12:05:22 CEST

Ben Collins-Sussman wrote:
> bliss@tigris.org wrote:
>> Author: bliss
>> Date: Sun Apr 25 11:55:38 2004
>> New Revision: 9496
>> Log:
>> Break apart the stream chunk size and the svndiff window size, and
>> make the latter an internal constant in libsvn_delta. Breaking these
>> apart makes it easy to adjust the delta window size without breaking
>> the API, and it's cleaner.
> So does this change get us closer to fixing issue #1789 ("win32 can't
> display large 'svn diff'")? If so, it looks like something we can
> backport to 1.0.3. Or do we have to wait for APR to fix the real problem?

No, because while this change makes it possible to change the stream
chunk size and the svndiff window size independantly, we cannot change
the stream chunk size because it's a constant in the exported API, and
as such might be used by other code to declare buffer sizes. If we
change the value, we risk breaking binary compatibility somewhere. It's
a tiny risk, but it's safer not to change it.

To solve the problems related to issue #1789, I'd like to obsolete the
SVN_STREAM_CHUNK_SIZE in the exported API, and use a new (smaller)
internal constant in the functions that copy stream data.

The real problem behind issue #1789 is in Windows, and it's not clear to
me if APR or Subversion should have to work around it. I did not get
any response when I asked the APR list. I guess it's easier to work
around the problem in Subversion.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Apr 26 12:05:37 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.