Fluff in delta combiner interface?
From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2004-04-23 20:14:13 CEST
I'm looking at svn_txdelta__compose_windows and the way it's used in
(1) It appears to have special handling for passing a second window
(2) There appear to be three redundant ways to check if the first
- The caller can check whether (window_B->src_ops == 0). This
- svn_txdelta__compose_windows() returns NULL.
- svn_txdelta__compose_windows() sets context->use_second to
In addition to doing its own check beforehand, libsvn_fs checks
I'd like to punt the context argument and the potential for returning
---------------------------------------------------------------------
|
This is an archived mail posted to the Subversion Dev mailing list.
This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.