Re: svn commit: r9462 - in trunk/subversion: libsvn_fs libsvn_fs_fs

> > - svn_fs_root_t *root = apr_pcalloc (subpool, sizeof (*root));
> > + svn_fs_root_t *root = apr_pcalloc (pool, sizeof (*root));
>
> Why this part of the change? There shouldn't be anything wrong with
> allocating the root from the subpool.

When the root is closed, there is a command like:

svn_pool_destroy (root->pool);

I may have been mistaken, but is it OK to destroy the pool that
contains the pointer to the pool you are destroying? If so, then I
will revert that portion of the change.

-Josh

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 23 04:39:11 2004