[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Reflow overly long lines in subversion/ tree

From: <kfogel_at_collab.net>
Date: 2004-04-19 17:27:34 CEST

Ben Collins-Sussman <sussman@collab.net> writes:
> > Can I make a small request? Since we're accepting such format-only
> > patches, could we please go through the code and get rid of the
> > space-before-paren mess? I don't mind the brace positioning (it's rather
> > cute, actually, and very readable once you get used to it), but those
> > spaces are a mess -- and the one thing about the GNU format that are
> > universally hated by everyone except RMS :-)
>
> Karl and I like the space-before-paren very much. We decided eons ago
> to just keep each .c file internally consistent: if it has
> space-before-paren, keep it that way. If you're creating a new file,
> chose space-before-paren or not. That's the reason ra_dav and ra_svn
> code has no space-before-paren; it was the choice of ghudson and
> gstein.
>
> Honestly, you don't want to open this bikeshed, do you? It's full of
> vipers. :-)

You're certainly free to go through adding the space where it's
currently missing, though.

<ducks>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Apr 19 18:43:14 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.