[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Phase 1 of Keywords as Hash

From: John Peacock <jpeacock_at_rowman.com>
Date: 2004-04-19 17:46:39 CEST

John Peacock wrote:

> I've taken a different tack with the proposed Keywords as Hash patch.
> Phase 1, attached, changes only libsvn_subr/svn_subst.c (and associated
> include files) and leave all of the rest of the core files untouched.
> This meant I could create and test the API compatibility layer
> independently of the changes to the remaining files.

Just to clarify and amplify something; this patch is 100% functional right now.
  All existing tests pass without change. It could be applied today and the
second part applied 6 months from now and no external changes would be visible.
  Phase 1 can (and should) be considered independently of Phase 2, which can be
realistically be called a clean up effort after Phase 1.

I'd appreciate it if it would be given serious review, so that if there are any
significant structural issues, I can revise this patch before submitting Phase
2, which is [obviously] dependent on this patch.



John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4501 Forbes Boulevard
Suite H
Lanham, MD  20706
301-459-3366 x.5010
fax 301-429-5748
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Apr 19 17:47:06 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.