[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Reflow overly long lines in subversion/ tree

From: Branko ─îibej <brane_at_xbc.nu>
Date: 2004-04-19 03:30:35 CEST

kfogel@collab.net wrote:

>"Erik Huelsmann" <e.huelsmann@gmx.net> writes:
>
>
>>Any body mind me committing the patch below? (with a somewhat more elaborate
>>Log message, ofcourse)
>>
>>Note that the patch affects lines in the bindings and libsvn_fs_fs too.
>>
>>I did not reflow lines of more than 80 characters in the (perl) native
>>bindings files and I was not sure how to reflow some of the C++ we have in
>>javahl.
>>
>>
>>Log:
>>[[[
>>Reflow overly long lines.
>>
>>* <all changed files go here>
>> Reflow lines with more than 80 characters
>>
>>]]]
>>
>>
>
>+1, especially now that the "_()" patches are applied :-).
>
>I don't think you need to list all the changed files, actually. It's
>the same change everywhere (see HACKING about this). You might want
>to mention the exceptions, though.
>
>
Can I make a small request? Since we're accepting such format-only
patches, could we please go through the code and get rid of the
space-before-paren mess? I don't mind the brace positioning (it's rather
cute, actually, and very readable once you get used to it), but those
spaces are a mess -- and the one thing about the GNU format that are
universally hated by everyone except RMS :-)

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Apr 19 03:30:51 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.