[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] - svn blame doesn't use the working revision (Issue 1777)

From: John Szakmeister <john_at_szakmeister.net>
Date: 2004-04-17 03:25:52 CEST

On Friday 16 April 2004 17:01, kfogel@collab.net wrote:
> We're not changing the signature, but we'd be very clearly changing
> the interface promise. The current API *promises* an error if you
> pass unspecified revision. Clients might be relying on that behavior.
> We can change a function's behavior to fix a bug. But making it
> behave the opposite to its documentation is not fixing a bug, it's a
> true interface change (though not a signature change).

I can see that. If there is one thing that I've learned from this project,
it's that it pays to follow the rules. :-) Thanks for explaining it.

> > If changing svn_client_blame() doesn't get us into 1.1, then I'd say
> > you and C. Mike are right, we just fix the inputs in the command line
> > client and wait until 2.0 to fix the API.
> Sounds good.
> > Yeah, that's too much for such a minor change. We should just file an
> > issue for a 2.0 change to the API, and take care of it then. I can do
> > that if no one objects to it.
> Thank you.

Done. It's Issue #1836.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Apr 17 03:29:12 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.