[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Fwd: Re: Broken Windows build.

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2004-04-16 18:36:17 CEST

C. Michael Pilato wrote:
> "Erik Huelsmann" <e.huelsmann@gmx.net> writes:
>
>
>>Sorry, meant to send to list.
>>--- Weitergeleitete Nachricht / Forwarded Message ---
>>Date: Fri, 16 Apr 2004 17:37:58 +0200 (MEST)
>>From: "Erik Huelsmann" <e.huelsmann@gmx.net>
>>To: "C. Michael Pilato" <cmpilato@collab.net>
>>Subject: Re: Broken Windows build.
>>
>>
>>>The file subversion/clients/cmdline/help-cmd.c has unconditional calls
>>>to gettext() in it. There is no documentation at all regarding
>>>gettext in INSTALL (that I could find with the obvious greps), and my
>>>Windows build is broken as a result of the gettext() calls.
>>
>>Garret added conditionals to svn_private_config.h to handle the
>>non-ENABLE_NLS case. Does that not apply to the Windows build?
>
>
> First, no, svn_private_config.hw is for Windows.
>
> Secondly, that section of the .h file just defines the _() macro --
> but help-cmd.c has direct calls to a function called gettext() in it!

I was under the impression (from previous discussions on the list) that
_() was just for literal strings. Literal calls to gettext() where
supposed to be used for text we can't enclose in _(), like when we have
an array of strings or something. Thus, the compatability define for
getext in the non-nls case.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 16 18:36:33 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.