Re: Broken Windows build.

"Erik Huelsmann" <e.huelsmann@gmx.net> writes:

> > The file subversion/clients/cmdline/help-cmd.c has unconditional calls
> > to gettext() in it. There is no documentation at all regarding
> > gettext in INSTALL (that I could find with the obvious greps), and my
> > Windows build is broken as a result of the gettext() calls.
>
> Which brings me to the question I was going to ask before Garret committed
> his #ifdef's:
>
> There are two possible ways to fix this (if Garret's commit does not):
>
> 1) Change the calls to _() calls
> 2) leave the gettext() calls but put those instances in #ifdef's

The gettext() calls are used in parameters to another function, so I'd
rather not see:

      function(param1,
   #ifdef ENABLE_NLS
               gettext(param2),
   #else
               param2,
   #endif
               param3,
               param4,
   #ifdef ENABLE_NLS
               gettext(param5),
   #else
               param5,
   #endif
               param6);

Knowwhatimean?

If those calls can just be changed to _(), that makes more sense. And
in addition, svn_private_config.hw needs to have a no-op _() macro
defined.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 16 17:53:41 2004