Re: svn commit: r9355 - in trunk/subversion: include libsvn_client

sussman@tigris.org writes:

> Author: sussman
> Date: Wed Apr 14 14:26:43 2004
> New Revision: 9355
>
> Modified:
> trunk/subversion/include/svn_error_codes.h
> trunk/subversion/libsvn_client/cat.c
> trunk/subversion/libsvn_client/client.h
> trunk/subversion/libsvn_client/ra.c
> Log:

> Modified: trunk/subversion/libsvn_client/ra.c
> ==============================================================================
> --- trunk/subversion/libsvn_client/ra.c (original)
> +++ trunk/subversion/libsvn_client/ra.c Wed Apr 14 14:26:43 2004

> + /* Set our return variables */
> + *start_url = svn_path_join (repos_url, lmb.start_path, pool);
> + *start_revision = apr_pcalloc (pool, sizeof (*start_revision));

I'd use palloc rather than pcalloc, but that's not really important.
What is important (as valgrind points out) is that it should be

   sizeof(**start_revision)

rather than

   sizeof(*start_revision)

> + (*start_revision)->kind = svn_opt_revision_number;
> + (*start_revision)->value.number = lmb.start_revision;
> + if (end->kind != svn_opt_revision_unspecified)
> + {
> + *end_url = svn_path_join (repos_url, lmb.end_path, pool);
> + *end_revision = apr_pcalloc (pool, sizeof (*end_revision));

ditto.

> + (*end_revision)->kind = svn_opt_revision_number;
> + (*end_revision)->value.number = lmb.end_revision;
> + }
> +
> return SVN_NO_ERROR;

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org