[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Issue 1780] Keyword values with dollar signs cause badness.

From: Ben Reser <ben_at_reser.org>
Date: 2004-04-14 21:12:41 CEST

On Tue, Apr 13, 2004 at 02:56:05PM -0000, kfogel@tigris.org wrote:
> Putting into 'future'. Definitely a bug, but it's probably pretty rare to
> encounter, and the workaround is simple ("don't do that"). Patch welcome.
> Some thoughts about a fix:
> A real escaping mechanism would "solve" this in some sense, but it would still
> affect the visible expansion of the keyword. The user would see
> $Author: j\$random $
> instead of
> $Author: j$random $
> I don't really see any reasonable way out of that, but it's a pity :-).

Why not simply do this:

$Author: "j$random" $

When we use quotes could be limited to when we're inserting a string
with $ in it to maintain compatability since this is a rare issue. In
the future depending upon where we see this fitting into our
compatability guarantees we can switch to always using $Keyword: "..." $

Ben Reser <ben@reser.org>
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Apr 14 21:13:58 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.