[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] svnlook and symlinked /tmp

From: Lachlan O'Dea <odela01_at_ca.com>
Date: 2004-04-14 04:57:52 CEST


Sorry if this is a repost, but my previous message didn't seem to
appear on the list...

I'm running Subversion 1.0.1 on FreeBSD 5.2.1. svnlook is having
trouble with my /tmp directory:

isis /tmp > svnlook diff /home/svn/repos -r 15
svn: Error creating dir '/tmp' (path exists)
svn: Can't open file '/tmp/svnlook.1/arclib/Makefile': No such file or

This happens because my /tmp happens to be a symbolic link. If I point
TMPDIR at a real directory it works. I think the correct fix is to have
svnlook use svn_io_check_resolved_path in open_writable_binary_file:

--- main.c.orig Wed Apr 7 11:50:37 2004
+++ main.c Wed Apr 7 12:19:39 2004
@@ -515,7 +515,7 @@
        svn_node_kind_t kind;
        const char *piece = ((const char **) (path_pieces->elts))[i];
        full_path = svn_path_join (full_path, piece, pool);
- SVN_ERR (svn_io_check_path (full_path, &kind, pool));
+ SVN_ERR (svn_io_check_resolved_path (full_path, &kind, pool));

        /* Does this path component exist at all? */
        if (kind == svn_node_none)

It worked for me.

Lachlan O'Dea
Computer Associates
Senior Software Engineer
tel: +61 3 8416 5627
fax: +61 3 8416 5810
mobile: +61 412 390 650
Relax and enjoy your shoes!
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Apr 14 06:59:26 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.