Re: svn commit: r9340 - trunk

"Max Bowsher" <maxb@ukf.net> writes:

> Ben Reser wrote:
>> On Mon, Apr 12, 2004 at 05:24:30PM -0500, maxb@tigris.org wrote:
>>> Author: maxb
>>> Date: Mon Apr 12 17:23:56 2004
>>> New Revision: 9340
>>>
>>> Modified:
>>> trunk/build.conf
>>> Log:
>>> * build.conf (libsvn_swig_py): Add "swig_runtime" to "libs".
>>>
>>>
>>> Modified: trunk/build.conf
>>>
> ============================================================================
> ==
>>> --- trunk/build.conf (original)
>>> +++ trunk/build.conf Mon Apr 12 17:23:56 2004
>>> @@ -323,7 +323,7 @@
>>> lang = python
>>> path = subversion/bindings/swig/python/libsvn_swig_py
>>> sources = swigutil_py.c
>>> -libs = libsvn_subr libsvn_delta aprutil apriconv apr
>>> +libs = swig_runtime libsvn_subr libsvn_delta aprutil apriconv apr
>>> install = swig-py-lib
>>> # need special build rule to include -DSWIGPYTHON
>>> compile-cmd = $(COMPILE_SWIG_PY)
>>
>> Maybe I missed something but umm what is swig_runtime for?
>
> Because swigutil_py.c uses several SWIG_* functions, and so needs to link
> against -lswigpy (at least on platforms which require all symbols to be
> defined at link-time - e.g. MSWindows).

Your change breaks my build (--with-swig=/usr/local/swig-1.3.21)

cd subversion/bindings/swig/python/libsvn_swig_py && /bin/sh /home/pm/sw/subversion/obj/libtool --silent --mode=link gcc -std=c89 -g -Wdeclaration-after-statement -Wtrigraphs -Wsign-compare -Wwrite-strings -Wpointer-arith -Wsequence-point -Wparentheses -Wall -Wshadow -Wmissing-prototypes -Wstrict-prototypes -Wmissing-declarations -DSVN_DEBUG -DSVN_DEBUG_ERROR -pthread -DNEON_ZLIB -DNEON_SSL -rpath /usr/local/subversion/lib -o libsvn_swig_py-1.la -no-undefined swigutil_py.lo -lswigpy ../../../../../subversion/libsvn_subr/libsvn_subr-1.la ../../../../../subversion/libsvn_delta/libsvn_delta-1.la /usr/local/apache2/lib/libaprutil-0.la -ldb -lexpat /usr/local/apache2/lib/libapr-0.la -lrt -lm -lcrypt -lnsl -lpthread -ldl -lz
/home/pm/sw/subversion/obj/subversion/bindings/swig/python/libsvn_swig_py
/usr/bin/ld: cannot find -lswigpy
collect2: ld returned 1 exit status
make: *** [subversion/bindings/swig/python/libsvn_swig_py/libsvn_swig_py-1.la] Error 1

That link is not using SWIG_LDFLAGS, the other links that use -lswigpy
use LINK_PY_WRAPPER.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org