[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: issue #1806 patch

From: <kfogel_at_collab.net>
Date: 2004-04-13 18:31:56 CEST

Garrett Rooney <rooneg@electricjellyfish.net> writes:
> >> - return err;
> >> + if ((err) && (err->apr_err == SVN_ERR_WC_LEFT_LOCAL_MOD))
> >> + {
> >> + return SVN_NO_ERROR;
> >> + }
> >> + else
> >> + return err;
> >> }
> >
> > A comment explaining why we trap the error would probably be good.
>
> Shouldn't that also clear the error before returning SVN_NO_ERROR?

Yikes, yes! Good catch, and sorry for missing that myself.

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Apr 13 19:46:25 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.