[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r9320 - trunk/subversion/libsvn_fs_fs

From: Erik Huelsmann <e.huelsmann_at_gmx.net>
Date: 2004-04-11 23:37:49 CEST

> > I've wondered about this a few times now seeing commits for
> > libsvn_fs_fs, but ...
> This is the first time I've committed libsvn_fs_fs code; how could you
> have wondered about this a few times?

I must be going mad; I can't find the commits I that made me wonder... Sorry
about that, but ...

> > ... don't belong comments like these in comment blocks in your code
> instead
> > of in the log message?
> Matter of opinion. The most important ones, like that node-IDs and
> changed-path information aren't handled yet, are also reflected in
> comments which show where stuff should be filled in. Things like "How
> to build this since there's no build system stuff yet" don't seem to be
> annotations about the code, and don't belong in my opinion.

... thanks for the explanation. I wouldn't have done that, but that is also
because I (until now) never saw information like this go into the log. Gives
me something to think about.



NEU : GMX Internet.FreeDSL
Ab sofort DSL-Tarif ohne Grundgebühr: http://www.gmx.net/info
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Apr 11 23:39:06 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.