Re: Should svn_hash_(read|write) accept streams?

Josh Pieper wrote:

>ghudson, sussman, and I were talking on IRC about how great it would
>be if svn_hash_(read|write) would accept svn_stream_t's. Then the
>equivalent code could be factorized out of the dumpfile loader, and
>re-used in the fs_fs code as well. The existing API could be
>trivially obtained by using svn_stream_from_aprfile, as well as handy
>things like reading hashes from stringbufs.
>
>So what are your thoughts about creating two new functions:
>svn_hash_read2 and svn_hash_write2 that accept svn_stream_t as
>
>
svn_hash_read_stream and svn_hash_write_stream, please. Make the
function names mnemonic.

>input/output. The originals could be removed at the next API change.
>
>
+1

(and the originals can't be removed until 2.0, which is not the next API
change :-)

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org