Re: [PATCH] Perl Bindings on Win32

On Sat, Apr 10, 2004 at 03:14:00PM -0400, Michael S. Liebman wrote:
> This patch does not fix the Perl bindings on Win32 but gets us a step
> closer and will hopefully help other people.
>
> Michael
>
> [[
> * subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c
> Replace 'long long' with apr_int64_t and 'unsigned long long'' with
> apr_uint64_t in svn_error_t
> ]]
>
> Index: subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c
> ===================================================================
> ---
> subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c
> (revision 9312)
> +++
> subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.c
> (working copy)
> @@ -312,14 +312,14 @@
> * it available as a string. If not then perl will convert
> * it to an IV for us. So this handles the problem gracefully
> */
> c = malloc(30);
> - snprintf(c,30,"%lld",va_arg(ap, long long));
> + snprintf(c,30,"%lld",va_arg(ap, apr_int64_t));
> XPUSHs(sv_2mortal(newSVpv(c, 0)));
> free(c);
> break;
>
> case 'U': /* unsigned long long */
> c = malloc(30);
> - snprintf(c,30,"%llu",va_arg(ap, unsigned long long));
> + snprintf(c,30,"%llu",va_arg(ap, apr_uint64_t));
> XPUSHs(sv_2mortal(newSVpv(c, 0)));
> free(c);
> break;

I really need to go through and look at all the callers of this
function. I want to clean up the formatting codes to be what we really
need. It's my intent to try to do this today as soon as I get through
all the subversion email.

-- 
Ben Reser <ben@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org