[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: I18n patch

From: Erik Hülsmann <e.huelsmann_at_gmx.net>
Date: 2004-04-09 23:47:53 CEST
('binary' encoding is not supported, stored as-is) >Well... this is the latest I've got. I'll now wait.. =)
>
>Note: There's not much to review here. All this changes are NOOP when
>"#define _(x) (x)".

Reviewed.

Running make && make check now.

I have a few comments about your patch, some of which have led to
tweaks:
- When adding function calls, please reindent all following lines
  to match the new nesting. For example:
    "This is"
    "multiline text"

  Changes to:
    _("This is"
      "Multiline text")

- Please keep line lengths below 80 columns.
- Most (not all) files adhere to the space-before-opening-paren style
  When adding function calls to a file please check for the
  code style used and adhere to that style.
- If you haven't read HACKING, please do so to find out about log
  messages, coding styles and all other stuff there is to know about
  the development process and procedures.

bye,

Erik.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 9 23:48:12 2004

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.